Skip to content

Configures the pvc.spec.storageClassName when it's not empty #10147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2022
Merged

Configures the pvc.spec.storageClassName when it's not empty #10147

merged 3 commits into from
May 23, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented May 20, 2022 •
edited
Loading

Description

Configures the pvc.spec.storageClassName when it's not empty. Otherwise, the PVC requests empty storage class.

Related Issue(s)

Fixes #10017
Fixes #9990

How to test

./dev/preview/install-k3s-kubeconfig.sh
cd test
go test -v ./... -run=TestMissingBackup -kubeconfig=/home/gitpod/.kube/config -namespace=default

Release Notes

[experimental] Workspace persistent volume claim (PVC) uses a default storage class within the Kubernetes cluster if the user does not configure it

Documentation

N/A

jenting added 2 commits May 23, 2022 09:54
@jenting
Configure the PVC storageClassName when it's non-empty string
b17fe66 
Otherwise, the Kubernetes tries to requesting a PVC with no storage class.

Signed-off-by: JenTing Hsiao <[email protected]>
@jenting
Add workspace integration test TestMissingBackup pvc part back
26c505c 
Signed-off-by: JenTing Hsiao <[email protected]>
@jenting jenting force-pushed the jenting/make-sure-pvc-is-working-10017 branch from ca08305 to 26c505c Compare May 23, 2022 01:54
@jenting
Fix unit test TestCreatePVCForWorkspacePod
acd56ee 
Update the golden file.

Signed-off-by: JenTing Hsiao <[email protected]>
@roboquat roboquat added size/M and removed size/S labels May 23, 2022
@jenting jenting marked this pull request as ready for review May 23, 2022 03:28
@jenting jenting requested a review from a team May 23, 2022 03:28
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 23, 2022
utam0k
utam0k reviewed May 23, 2022
View reviewed changes
utam0k
utam0k approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine

@roboquat roboquat merged commit 1646db7 into main May 23, 2022
@roboquat roboquat deleted the jenting/make-sure-pvc-is-working-10017 branch May 23, 2022 04:00
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure PVC is working in dev environment Fix broken workspace integration test TestMissingBackup(PVC)
3 participants
@jenting @utam0k @roboquat