Skip to content

Do not allow prebuilds when GitHub app is not configured or GitLab webhook is removed #7009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gtsiolis opened this issue Dec 2, 2021 · 1 comment
Closed

Do not allow prebuilds when GitHub app is not configured or GitLab webhook is removed #7009

gtsiolis opened this issue Dec 2, 2021 · 1 comment
Labels
component: dashboard feature: prebuilds team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 2, 2021

Problem to solve

When a user removes or reconfigures the Github app, removes the GitLab webhook, or is removed from a project, you can still trigger a prebuild from the dashboard.

For GitHub, the prebuild go through the RUNNING and SUCCESS states with no error.

For GitLab, the prebuild go through the RUNNING and SUCCESS states with the following error:

last backup failed: workspace does not exist. Please contact support if you need the workspace data.

Proposal

Do not allow prebuilds when GitHub app is not configured or GitLab webhook is removed
@gtsiolis gtsiolis added component: dashboard feature: prebuilds type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Dec 2, 2021
@gtsiolis gtsiolis mentioned this issue Dec 2, 2021
Open
@gtsiolis gtsiolis mentioned this issue Dec 16, 2021
Closed
@jldec
Copy link
Contributor

jldec commented Jan 1, 2022

thanks! 🙏 @gtsiolis

  • It would indeed be nice to handle the missing webhook/app config with an indicator as suggested as in Show prebuild configuration state on the project prebuilds page  #7010
  • But, I don't think we should prevent manually triggered prebuilds in this case - Allowing users to work without the automation seems reasonable to me.
  • I could not reproduce the GitLab error which you mentioned probably because I'm not following the same steps that you did - would you mind opening a separate issue with more details for reproducing so that we can investigate the cause of this bug?

@jldec jldec closed this as completed Jan 1, 2022
@jldec jldec moved this to Done in 🍎 WebApp Team Jan 1, 2022
@jldec jldec removed this from 🍎 WebApp Team Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dashboard feature: prebuilds team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gtsiolis @jldec