Rename the prebuild trigger action

[gtsiolis]

Problem to solve

Using the the verb trigger as a call-to-action may be confusing or complex for some users, see relevant discussion:

George: What do you think of renaming the action verb to Run and change this to Run Prebuild to make it sound less complex? We can keep the metadata information with the same verb (Triggered 2 minutes ago). Maybe also something to change in a future iteration.

Jan: Ah, I was confused by what this "Trigger Prebuild" meant. What is the intent? Is it to "Re-try Failed Prebuild"?

Cc @jankeromnes @AlexTugarev

Proposal

We could rename the call to action verb to Run so that Trigger Prebuild becomes Run Prebuild. 🏃

We also need to take into account how we use this verb when retrying a successful or failed prebuild. ❓

TBD (To be discussed)

[jankeromnes]

Actually, I thought we had agreed that the context menu entry would be Retrigger Prebuild (or Rerun Prebuild), and would only be available for failed, cancelled, or timed-out prebuilds.

Reason: There is no point in re-triggering a prebuild that has already succeeded(!)

Note: This is different from the top-level action button Trigger Prebuild (i.e. "trigger a new prebuild for the default branch"), which seems fine for now (but also doesn't really make sense when there is already a successful prebuild for the latest commit of the default branch)

[gtsiolis]

There is no point in re-triggering a prebuild that has already succeeded(!)

You are probably right here! 💯

Cross-posting some points from a relevant discussion (internal):

Let’s not allow retriggering when READY.

There’s also another state CANCELED which could also allow retriggering.

🍊 🍊 🍊 🍊

... but also doesn't really make sense when there is already a successful prebuild for the latest commit of the default branch

Agree but this is action button is mainly for adding support to run ad-hoc prebuilds for a specific branches, when a prebuild for the default branch is garbaged collected, potentially injecting runtime environment variables, and more.

For the same linked discussion:

The trigger prebuild (run prebuild) action on top right could be skipped for now but I think we’ll eventually need this for the following two use minor cases but I could be wrong:

1. A user goes back to a non active project and wants to trigger a prebuild for the default branch.

2. A team is working a project in non-default branches for a couple of weeks and someone wants to trigger a prebuild for the default branch.

In terms of UX, this button could trigger a modal to confirm prebuild on the default branch. Possible improvements could include selecting a different branch, passing an env var for a prebuild, etc.

🍋 🍋 🍋 🍋

Also, we could also move forward with removing the button for now if it does not seem useful to you. Cc @jankeromnes @AlexTugarev

However, let’s remove that button for now to make the implementation scope smaller as it also does not seem much useful at the moment.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.