[ws-manager] workspaces failed to start

[atduarte]

Bug description

Tried opening workspaces for a side-project and it failed to start at least two times.

Two errors I didn't have time to read showed up in quick succession, and the workspace stopped before it actually started. When I clicked in the "Open Workspace" button that showed up in the "Stopped" page, I got the following error: "cannot initialize workspace: cannot initialize workspace: no backup found".

Steps to reproduce

It was happening for every workspace started, but not anymore.

Workspace affected

atduarte-revispt-960nm6i1khz, atduarte-revispt-jsh4ofkpnyz

Expected behavior

No response

Example repository

No response

Anything else?

No response

[kylos101]

Thanks for the heads up, we initially addressed in generation 44. Therefore, there's still some work to do, scheduled.

[sagor999]

I believe this is due to failure to make prior backup, like when ws-daemon crashes.
To make it easier to debug later on, here is PR: #10491
that makes sure that we will surface if there was an actual error when attempting to download backup.
Once that PR is merged and deployed, I will check logs again to see if there is anything else going on.

[atduarte]

@sagor999 the example workspace ids provided are from fresh starts (of a project with prebuilds) that failed and a few minutes later, trying again, started working.