Fix custom hook output #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dblessing
commented
Nov 12, 2014
dblessing
commented
- Show stdout and stderr. Hooks might need to output info to user even if successful.
dblessing
force-pushed
the
fix/custom_hook_output
branch
from
ffdc8f9 to
d7f77f6
Compare
| end | ||
|
|
dblessing
force-pushed
the
fix/custom_hook_output
branch
from
d7f77f6 to
17e2c2c
Compare
| @@ -22,7 +22,8 @@ def post_receive(changes, repo_path) | |||
| def update(ref_name, old_value, new_value, repo_path) | |||
| hook = hook_file('update', repo_path) | |||
| return true if hook.nil? | |||
| system(hook, ref_name, old_value, new_value) ? true : false | |||
| system(hook, ref_name, old_value, new_value) | |||
| $?.exitstatus == 0 ? true : false | |||
There was a problem hiding this comment.
why use global variable if system returns valid value?
There was a problem hiding this comment.
You're right, sorry. I misunderstood how system works. Fixed.
dblessing
force-pushed
the
fix/custom_hook_output
branch
from
17e2c2c to
57c9080
Compare
dblessing
changed the title
|
@randx I hope this can slip in to a release for GitLab 7.5. Otherwise users could be confused if they're testing custom hooks |
|
@dblessing I doubt it but it is up to @jacobvosmaer |
|
FYI: current |
|
This is a nice improvement but I think it is not worth the hassle this close to the 7.5.0 release. |
|
Thanks @dblessing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.