Skip to content

Added list-projects command & spec #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2014

Conversation

david-martin
Copy link
Contributor

./bin/gitlab-projects list-projects

aaa.git
dmtest1.git
ns/dmtest2.git
x/y/z.git

@david-martin
Copy link
Contributor Author

@Razer6 @jvanbaarsen Where are we with getting this PR merged back?
Are there any remaining actions on my part?

@Razer6
Copy link
Member

Razer6 commented Oct 15, 2014

@randx Can you take a look after 7.4 release?

@Razer6 Razer6 added this to the 7.5 milestone Oct 15, 2014
@@ -91,6 +92,13 @@ def add_project
system(*cmd) && self.class.create_hooks(full_path)
end

def list_projects
$logger.info "Listing projects"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change strings to single line quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Is there a task/command to run houndci locally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

FileUtils.mkdir_p(tmp_repos_path)
end

it "should create projects and list them" do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

list-projects command usage

Single quotes

Use single quotes

Use single quotes
dzaporozhets added a commit that referenced this pull request Oct 28, 2014
Added list-projects command & spec
@dzaporozhets dzaporozhets merged commit 8f9c11a into gitlabhq:master Oct 28, 2014
@grdryn grdryn deleted the projects_list branch September 21, 2017 15:35
maxlazio pushed a commit that referenced this pull request May 1, 2019
Support calling internal API using HTTPS

Closes #179

See merge request gitlab-org/gitlab-shell!297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants