-
Notifications
You must be signed in to change notification settings - Fork 313
Added list-keys command, with associated spec #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
david-martin
commented
Sep 16, 2014
keys = "" | ||
File.readlines(auth_file).each do |line| | ||
# key_id & public_key | ||
# command="/home/git/gitlab-shell/bin/gitlab-shell key-741",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-rsa AAAAB3NzaDAxx2E\n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [155/80]
@david-martin Can you please fix the comments placed hy @houndci ? You can ignore the Double quote ones. |
@@ -41,6 +41,19 @@ | |||
end | |||
end | |||
|
|||
describe :list_keys do | |||
let(:gitlab_keys) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using {...} for multi-line blocks.
eb5f3bb
to
fef7860
Compare
Can you also please change all double quote strings to single quoted ones? |
@Razer6 conflicting pov from you ,@jvanbaarsen & the hound. |
@david-martin Always use single quotes. Hound is currently misconfigured. See #178 for the pending PR |
d5a0fe0
to
4e044b0
Compare
@Razer6 double quotes are required for string interpolation in 2 places. I'm not going to change these. |
That's fine! We know, that not 100% of code matches hound style guide. But we enabled hound, that at least new code follows the style guide. |
59fa261
to
58d9163
Compare
@Razer6 @jvanbaarsen Where are we with getting this PR merged back? |
@@ -38,6 +39,19 @@ def add_key | |||
true | |||
end | |||
|
|||
def list_keys | |||
$logger.info "Listing all keys" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change strings to single line quotes?
58d9163
to
e9e8205
Compare
@@ -38,6 +39,19 @@ def add_key | |||
true | |||
end | |||
|
|||
def list_keys | |||
$logger.info 'Listing all keys' | |||
keys = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Removed puts and tidied up regex Address the hound Address the hound, again Use single quotes Add back travis.yml file Remove travis.yml, only keep on fh-master Use single quotes Use single quotes
e9e8205
to
89d8af4
Compare
@Razer6 done. houndci has quietened down now. Anything other changes required to get this merged? |
@randx Can you take a look? |
Added list-keys command, with associated spec