Skip to content

Don't use query param for the POST requests #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Don't use query param for the POST requests #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
632279d
Don't use query param for the POST requests
jmini Nov 28, 2024
bb5b149
fix format
jmini Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/main/java/org/gitlab4j/api/EpicsApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,7 @@ public Epic createEpic(
.withParam("start_date", startDate)
.withParam("end_date", endDate)
.withParam("created_at", createdAt);
Response response =
post(Response.Status.CREATED, formData.asMap(), "groups", getGroupIdOrPath(groupIdOrPath), "epics");
Response response = post(Response.Status.CREATED, formData, "groups", getGroupIdOrPath(groupIdOrPath), "epics");
return (response.readEntity(Epic.class));
}

Expand Down Expand Up @@ -363,8 +362,7 @@ public Epic createEpic(Object groupIdOrPath, Epic epic) throws GitLabApiExceptio
.withParam("start_date", epic.getStartDate())
.withParam("end_date", epic.getEndDate())
.withParam("created_at", epic.getCreatedAt());
Response response =
post(Response.Status.CREATED, formData.asMap(), "groups", getGroupIdOrPath(groupIdOrPath), "epics");
Response response = post(Response.Status.CREATED, formData, "groups", getGroupIdOrPath(groupIdOrPath), "epics");
return (response.readEntity(Epic.class));
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/gitlab4j/api/RunnersApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ public RunnerDetail registerRunner(
.withParam("run_untagged", runUntagged, false)
.withParam("tag_list", tagList, false)
.withParam("maximum_timeout", maximumTimeout, false);
Response response = post(Response.Status.CREATED, formData.asMap(), "runners");
Response response = post(Response.Status.CREATED, formData, "runners");
return (response.readEntity(RunnerDetail.class));
}

Expand Down