refactor: extract state notification logic #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmulholland
approved these changes
Mar 1, 2024
Collaborator
bmulholland
left a comment
bmulholland
left a comment
There was a problem hiding this comment.
I'm assuming this is pretty much just moved code, not any functional changes. Approving on that basis -- I haven't reviewed each individual line. If there are functionality changes too, please point them out so I can take a closer look.
Member
Author
that's correct, pretty much just moved across. |
adufr
pushed a commit
to adufr/gitify
that referenced
this pull request
Mar 25, 2024
* refactor: extract state notification logic * refactor tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #829
Extracts the notification state logic into it's own file. Also refactored the test suite to be clearer on the scenarios being tested