Make visible menu window on all workspaces #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OS X, gitify is now bound to specific work space where gitify firstly started. When I click the menu icon in other workspace, the window will be opened in the bound work space and current workspace is forced to be changed. I used `BrowserWindow.setVisibleOnAllWorkspaces()` API to solve this issue. https://github.com/atom/electron/blob/master/docs/api/browser-window.md#browserwindowsetvisibleonallworkspacesvisible I think all menu bar application should set this option to true.
manosim
added
the
enhancement
Contributor
Author
|
I think this PR can improve #20. |
Member
|
I've tried it before and I think it didn't work (maybe in older versions of Electron? who knows..) but now it works great! Thank you @rhysd! 🚀 |
manosim
pushed a commit
that referenced
this pull request
Aug 12, 2015
Make visible menu window on all workspaces
Contributor
Author
|
✨🐶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Thank you for such a great app.
In OS X, gitify is now bound to specific work space where gitify firstly started. When I click the menu icon in other workspace, the window will be opened in the bound work space and current workspace is forced to be changed.
I used
BrowserWindow.setVisibleOnAllWorkspaces()API to solve this issue.https://github.com/atom/electron/blob/master/docs/api/browser-window.md#browserwindowsetvisibleonallworkspacesvisible
I think all menu bar applications should set this option to true.