Update dist script & Remove client secret key #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manosim
changed the title
manosim
pushed a commit
that referenced
this pull request
Aug 1, 2015
Update dist script & Remove client secret key
|
Did this really change anything, the secrets are still in the repo and they can still be read even after the asar step. I guess ultimately it's a risk we have to make when using oauth clientside. |
Member
Author
|
Hello @iKlsR. This is quite an old PR - The keys that you see in the repository are used only for development - there are separate production keys. You can find more information in the README: https://github.com/manosim/gitify#development I think we should investigate if there is something we can do to hide them after the asar step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75 .