Added "Open at startup" option #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2015 22:32
manosim
added
the
enhancement
Member
|
That looks really nice @sergiovilar ! Will give it a try ASAP and let you know how it goes! Can you also fix the test coverage? If not, I can give it a go! |
Author
|
Hi @ekonstantinidis, thanks! I fixed in the last commit, it's all passing as you can see here. |
Member
|
While it seems to work (it does open when the mac starts), it seems that when you toggle the setting("Open at start up") the UI crashes. To reproduce just toggle that setting and then press the back button - for me it doesn't go back. Will have a further look too! |
Author
|
@ekonstantinidis I'll take a look! |
Author
|
@ekonstantinidis now seems to be working fine! Please take a look 😄 |
Member
|
@sergiovilar Works niiice! Merged & thanks! 🚀 🚀 🚀 |
manosim
pushed a commit
that referenced
this pull request
Jul 25, 2015
Added "Open at startup" option
Author
|
😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65 .