Skip to content

Fix bad mock #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Fix bad mock #139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e262bb
Actually mock date in time-ago tests
koddsson Jun 1, 2020
dde1d80
Fix one off error in broken test
koddsson Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions test/time-ago.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,30 @@
suite('time-ago', function() {
let dateNow

function freezeTime(date) {
dateNow = Date.now
Date.now = function() {
return date
function freezeTime(expected) {
dateNow = Date

function MockDate(...args) {
if (args.length) {
return new dateNow(...args)
}
return new dateNow(expected)
}

MockDate.UTC = dateNow.UTC
MockDate.parse = dateNow.parse
MockDate.now = () => expected.getTime()
MockDate.prototype = dateNow.prototype

// eslint-disable-next-line no-global-assign
Date = MockDate
}

teardown(function() {
if (dateNow) {
Date.now = dateNow
// eslint-disable-next-line no-global-assign
Date = dateNow
dateNow = null
}
})

Expand Down Expand Up @@ -61,7 +75,7 @@ suite('time-ago', function() {

test('rewrites time-ago datetimes < 18months as "months ago"', function() {
freezeTime(new Date(2020, 0, 1))
const then = new Date(2018, 10, 1).toISOString()
const then = new Date(2018, 9, 1).toISOString()
const timeElement = document.createElement('time-ago')
timeElement.setAttribute('datetime', then)
assert.equal(timeElement.textContent, '15 months ago')
Expand Down