Bump nokogiri to 1.18, require at least Ruby 3.1 #1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the nokogiri dependency to version 1.18.4 and updates the required Ruby version to at least 3.1, ensuring compatibility with newer Ruby releases.
- Update gemspec: bumps Ruby requirement and nokogiri version.
- Update Gemfile: adds nokogiri with the updated version.
- Update CI workflow: removes Ruby 3.0 from the test matrix and adds Ruby 3.4.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| github-markup.gemspec | Updated required Ruby version and bumped nokogiri dependency. |
| Gemfile | Added nokogiri gem with the new version constraint. |
| .github/workflows/ci.yml | Adjusted CI matrix to remove Ruby 3.0 and include Ruby 3.4. |
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
TylerDixon
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://github.com/github/markup/security/dependabot/48 et al
How
Bump nokogiri and ensure that we require Ruby > 3.1
TODO
Meta
supersedes #1946