Skip to content

Conversation

stephenotalora
Copy link
Contributor

@stephenotalora stephenotalora commented Sep 9, 2021

closes #135

Applies solution by typescript-eslint https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-invalid-this.md

verified that by applying this overwrite the error provided in issue #135 is fixed as part of our project rules.

@stephenotalora stephenotalora requested a review from a team as a code owner September 9, 2021 18:08
Copy link
Contributor

@manuelpuyol manuelpuyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manuelpuyol manuelpuyol merged commit 641649a into github:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable base no-invalid-this rule in favor of @typescript-eslint/no-invalid-this
3 participants