Skip to content

Conversation

@khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Dec 4, 2021

Closes #7

This PR introduces a rake task and a GitHub action to ensure that every rule has an associated documentation page.

Here is a successful run of this action

@khiga8 khiga8 force-pushed the kh-create_docs_action branch from 37212bb to 677289f Compare December 5, 2021 18:01
@khiga8 khiga8 marked this pull request as ready for review December 5, 2021 18:12
Enabled: false

Rails/RakeEnvironment:
Enabled: false
Copy link
Collaborator Author

@khiga8 khiga8 Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting a rubocop error for this line, Rails/RakeEnvironment, but disabling it because this repo isn't running a Rails app so this rule isn't applicable.

- [GitHub::Accessibility::ImageHasAlt](./docs/rules/accessibility/no-aria-label-misuse.md)
- [GitHub::Accessibility::NoAriaLabelMisuse](./docs/rules/accessibility/image-has-alt.md)
- [GitHub::Accessibility::ImageHasAlt](./docs/rules/accessibility/image-has-alt.md)
- [GitHub::Accessibility::NoAriaLabelMisuse](./docs/rules/accessibility/no-aria-label-misuse.md)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing this mistake, while I'm here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@khiga8 khiga8 requested review from a team, bolonio, joelhawksley and smockle December 6, 2021 15:10
@joelhawksley joelhawksley removed their request for review December 6, 2021 18:42
@khiga8 khiga8 merged commit 4a9e2c6 into main Dec 10, 2021
@khiga8 khiga8 deleted the kh-create_docs_action branch December 10, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create rake task to ensure all rules are properly documented.

3 participants