Skip to content

Add avoid both disabled and aria disabled rule #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2021
Merged

Add avoid both disabled and aria disabled rule #11

merged 1 commit into from
Dec 27, 2021

Conversation

@khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Dec 27, 2021

This PR ports over a linter rule that raises when both disabled and aria-disabled are being set.

@khiga8 khiga8 requested review from a team, bolonio and inkblotty December 27, 2021 20:23
inkblotty
inkblotty approved these changes Dec 27, 2021
View reviewed changes
Copy link

@inkblotty inkblotty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khiga8 khiga8 merged commit 89ff6e8 into main Dec 27, 2021
@khiga8 khiga8 deleted the kh-avoid_both_disabled_and_aria_disabled branch December 27, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inkblotty inkblotty inkblotty approved these changes

@bolonio bolonio Awaiting requested review from bolonio bolonio is a code owner automatically assigned from github/accessibility-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khiga8 @inkblotty