Issue #4283 rewording section #4289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue github#4283 Line 80 has been changed from Users have specific permissions for each repository, so having the GITHUB_TOKEN for one repository grant access to another would impact the GitHub permission model if not implemented carefully. to Users have specific permissions for each repository, so allowing the GITHUB_TOKEN for one repository to grant access to another would impact the GitHub permission model if not implemented carefully.
janiceilene
approved these changes
Mar 5, 2021
Contributor
There was a problem hiding this comment.
👋 @MeetYourCreator Thanks so much for opening a PR to fix up this sentence! Your changes look great and I'll get this merged shortly.
Next time, if you use the syntax closes #4283 in the pull request template, your PR will be automatically linked to the issue you're closing 💖 You can read some more about it in Linking a pull request to an issue. When the issue and PR are linked, then the issue is automatically closed when we merge your PR ✨
We so appreciate your help and passion for GitHub docs!
janiceilene
added
actions
Author
|
Thanks so much @janiceilene! And thank you for the helpful link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Issue #4283
What's being changed:
Line 80, from:
Users have specific permissions for each repository, so having the GITHUB_TOKEN for one repository grant access to another would impact the GitHub permission model if not implemented carefully.
to
Users have specific permissions for each repository, so allowing the GITHUB_TOKEN for one repository to grant access to another would impact the GitHub permission model if not implemented carefully.
Check off the following: