Skip to content

Updates repo topics URL for GHES docs #34007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Conversation

IAmHughes
Copy link
Contributor

@IAmHughes IAmHughes commented Jul 17, 2024

Why:

GHES users shouldn't be pointed to the URL for GitHub.com topics. They should be pointed to their instance's topics list instead.

Closes: #34006

What's being changed (if available, include any code snippets, screenshots, or gifs):

I've updated the documentation to continue to link to the GitHub.com URL when on GHEC or FPT, but when on GHES it will display https://HOSTNAME/topics following the same nomenclature used in other documentation for GHES such as about remote repositories

Old

image

New

image

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 17, 2024
Copy link
Contributor

github-actions bot commented Jul 17, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/classifying-your-repository-with-topics.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@IAmHughes IAmHughes marked this pull request as ready for review July 17, 2024 13:30
Carlo0704

This comment was marked as spam.

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Jul 18, 2024
@nguyenalex836
Copy link
Contributor

@IAmHughes Thanks so much for opening a PR! I'll get this triaged for review ✨

lecoursen
lecoursen previously approved these changes Jul 22, 2024
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IAmHughes, very cool to see you again! 💖 I'm going to apply a small suggestion and then merge. ⚡

@lecoursen lecoursen enabled auto-merge July 22, 2024 15:53
@lecoursen lecoursen added this pull request to the merge queue Jul 22, 2024
Merged via the queue into github:main with commit 0fe8e55 Jul 22, 2024
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo topics URL points to GitHub.com in GHES docs
4 participants