Skip to content

Fix Text #25471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 13, 2023
Merged

Fix Text #25471

merged 19 commits into from
Nov 13, 2023

Conversation

Sriparno08
Copy link
Contributor

@Sriparno08 Sriparno08 commented May 9, 2023

Why:

This change will allow users to use the right command.

Closes: #25314

What's being changed (if available, include any code snippets, screenshots, or gifs):

I have changed:

  • theme: THEME-NAME to theme: jekyll-theme-THEME-NAME
  • theme: minima to theme: jekyll-theme-minima

GitHub Docs URL: https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/adding-a-theme-to-your-github-pages-site-using-jekyll

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/setting-up-a-github-pages-site-with-jekyll/adding-a-theme-to-your-github-pages-site-using-jekyll.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@Sriparno08 Thanks for submitting a PR! I'm going to triage this but place it on hold per comment here as we investigate it a bit further. 👍

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels May 10, 2023
rnsishan

This comment was marked as resolved.

@Sriparno08
Copy link
Contributor Author

Hey @cmwilson21, is there any update on the PR?

@cmwilson21
Copy link
Contributor

@Sriparno08 Thanks for checking in! Sorry for the delay, we've had to do a bit of digging as to why this doesn't work for all themes. Still working on it, though!

@Sriparno08
Copy link
Contributor Author

Its OK, @cmwilson21 👍

Thanks for the update!

@Sriparno08
Copy link
Contributor Author

Hey @cmwilson21, is there any update?

Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update supported theme example, following this content design plan.

@vgrl
Copy link
Contributor

vgrl commented Nov 10, 2023

We're having a small problem with our preview deployments at this moment, once that's resolved I'll double check these changes on preview and then get this merged if all looks good! ⚡

@Sriparno08
Copy link
Contributor Author

Okay, @vgrl 👍

Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked on preview and looks good! ⚡. I'll go ahead and get this merged.

@vgrl vgrl enabled auto-merge November 13, 2023 21:39
@vgrl vgrl added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Nov 13, 2023
@vgrl vgrl closed this Nov 13, 2023
auto-merge was automatically disabled November 13, 2023 21:49

Pull request was closed

@vgrl vgrl reopened this Nov 13, 2023
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 13, 2023
@vgrl vgrl removed the triage Do not begin working on this issue until triaged by the team label Nov 13, 2023
@vgrl vgrl added this pull request to the merge queue Nov 13, 2023
Merged via the queue into github:main with commit fb16ee9 Nov 13, 2023
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Sriparno08 Sriparno08 deleted the fix-text branch December 5, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Add theme to Pages site"
4 participants