-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Fix Text #25471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Text #25471
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@Sriparno08 Thanks for submitting a PR! I'm going to triage this but place it on hold per comment here as we investigate it a bit further. 👍 |
Hey @cmwilson21, is there any update on the PR? |
@Sriparno08 Thanks for checking in! Sorry for the delay, we've had to do a bit of digging as to why this doesn't work for all themes. Still working on it, though! |
Its OK, @cmwilson21 👍 Thanks for the update! |
Hey @cmwilson21, is there any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update supported theme example, following this content design plan.
...-up-a-github-pages-site-with-jekyll/adding-a-theme-to-your-github-pages-site-using-jekyll.md
Outdated
Show resolved
Hide resolved
We're having a small problem with our preview deployments at this moment, once that's resolved I'll double check these changes on preview and then get this merged if all looks good! ⚡ |
Okay, @vgrl 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checked on preview and looks good! ⚡. I'll go ahead and get this merged.
Pull request was closed
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
This change will allow users to use the right command.
Closes: #25314
What's being changed (if available, include any code snippets, screenshots, or gifs):
I have changed:
theme: THEME-NAME
totheme: jekyll-theme-THEME-NAME
theme: minima
totheme: jekyll-theme-minima
GitHub Docs URL: https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/adding-a-theme-to-your-github-pages-site-using-jekyll
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.