Skip to content

Add example for object filter on object. #15698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Robert98MG
Copy link

@Robert98MG Robert98MG commented Feb 22, 2022

There was already an example for using an object filter on an array.
Clarify that object filters can be used on objects as well and that the
result is an array, not an object.

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

There was already an example for using an object filter on an array.
Clarify that object filters can be used on objects as well and that the
result is an array, not an object.
@welcome
Copy link

welcome bot commented Feb 22, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 22, 2022
@ramyaparimi
Copy link
Contributor

@Robert98MG There was already another PR opened with the exact same changes. So, I am closing this PR in favor of this already opened PR 💛

You can find more "help wanted" issues here ✨ Thanks a bunch for taking your time in contributing to GitHub docs 💖

@Robert98MG Robert98MG deleted the pr/15697 branch February 26, 2022 20:03
@Robert98MG Robert98MG restored the pr/15697 branch February 26, 2022 20:03
@Robert98MG Robert98MG deleted the pr/15697 branch February 26, 2022 20:04
@Robert98MG Robert98MG restored the pr/15697 branch February 26, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants