-
Notifications
You must be signed in to change notification settings - Fork 62.1k
Add example for object filter on object. #15697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@Kurt-von-Laven |
Great addition @Kurt-von-Laven - thanks much. I made one minor suggestion but this is 👍 |
Thank you for the review, @ethomson! |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
I believe the build failure is unrelated to this pull request. |
I rebased on the latest version of main, and this time all of the checks passed. I suspect the previous failure may have been caused by a flaky test. |
@Kurt-von-Laven We are looking into the fix. I will get this merged once the tests are passing. Thanks so much for your patience 💖 Ah, I see this PR is still under review. I will get this merged once the review is done and approved 💖. Thanks so much for your patience. |
Sounds good. The flaky test theory is supported by the fact that the tests sometimes fail and sometimes succeed when all I am doing is rebasing on the latest changes. |
There was already an example for using an object filter on an array. Clarify that object filters can be used on objects as well and that the result is an array, not an object.
@ethomson, I rebased on the latest main, and now all tests are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from Docs ✨
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
There was already an example for using an object filter on an array. Clarify that object filters can be used on objects as well and that the result is an array, not an object.
Why:
Closes #11762.
What's being changed:
Content only; refer to rich diff.
Check off the following:
Writer impact (This section is for GitHub staff members only):