Skip to content

Add example for object filter on object. #15697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2022
Merged

Add example for object filter on object. #15697

merged 2 commits into from
Mar 25, 2022

Conversation

Kurt-von-Laven
Copy link
Contributor

@Kurt-von-Laven Kurt-von-Laven commented Feb 22, 2022 •
edited
Loading

There was already an example for using an object filter on an array. Clarify that object filters can be used on objects as well and that the result is an array, not an object.

Why:

Closes #11762.

What's being changed:

Content only; refer to rich diff.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Feb 22, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 22, 2022
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Feb 22, 2022
@ramyaparimi
Copy link
Contributor

@Kurt-von-Laven
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi mentioned this pull request Feb 22, 2022
Closed
5 tasks
ethomson
ethomson reviewed Mar 1, 2022
View reviewed changes
@ethomson
Copy link
Contributor

ethomson commented Mar 1, 2022

Great addition @Kurt-von-Laven - thanks much. I made one minor suggestion but this is 👍

@Kurt-von-Laven
Copy link
Contributor Author

Thank you for the review, @ethomson!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/learn-github-actions/expressions.md Modified Original

@Kurt-von-Laven Kurt-von-Laven requested a review from ethomson March 1, 2022 22:20
@Kurt-von-Laven
Copy link
Contributor Author

I believe the build failure is unrelated to this pull request.

@skedwards88 skedwards88 added ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review and removed waiting for review Issue/PR is waiting for a writer's review ready to merge This pull request is ready to merge labels Mar 3, 2022
@Kurt-von-Laven
Copy link
Contributor Author

I rebased on the latest version of main, and this time all of the checks passed. I suspect the previous failure may have been caused by a flaky test.

@ramyaparimi ramyaparimi enabled auto-merge March 10, 2022 13:02
@ramyaparimi
Copy link
Contributor

ramyaparimi commented Mar 10, 2022 •
edited
Loading

@Kurt-von-Laven We are looking into the fix. I will get this merged once the tests are passing. Thanks so much for your patience 💖

Ah, I see this PR is still under review. I will get this merged once the review is done and approved 💖. Thanks so much for your patience.

@ramyaparimi ramyaparimi disabled auto-merge March 10, 2022 13:11
@Kurt-von-Laven
Copy link
Contributor Author

Sounds good. The flaky test theory is supported by the fact that the tests sometimes fail and sometimes succeed when all I am doing is rebasing on the latest changes.

@Kurt-von-Laven
Add example for object filter on object.
4ce6cff 
There was already an example for using an object filter on an array.
Clarify that object filters can be used on objects as well and that the
result is an array, not an object.
@Kurt-von-Laven
Copy link
Contributor Author

@ethomson, I rebased on the latest main, and now all tests are passing.

@ramyaparimi ramyaparimi added the needs SME This proposal needs review from a subject matter expert label Mar 25, 2022
mchammer01
mchammer01 approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Docs ✨

@mchammer01 mchammer01 added ready to merge This pull request is ready to merge and removed needs SME This proposal needs review from a subject matter expert labels Mar 25, 2022
@ramyaparimi ramyaparimi enabled auto-merge March 25, 2022 18:05
@ramyaparimi ramyaparimi merged commit ab4d585 into github:main Mar 25, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Kurt-von-Laven Kurt-von-Laven deleted the patch-2 branch March 25, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

@ethomson ethomson Awaiting requested review from ethomson

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document Object Element Dereference Syntax
6 participants
@Kurt-von-Laven @ramyaparimi @ethomson @mchammer01 @skedwards88 @Robert98MG