Skip to content

Swift: Clarify the tag in the Swift updating doc #19558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redsun82 merged 1 commit into from
May 22, 2025
Merged

Swift: Clarify the tag in the Swift updating doc #19558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions swift/third_party/resources/updating.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ These files can only be updated having access for the internal repository at the
In order to perform a Swift update:

1. Dispatch the [internal `swift-prebuild` workflow](https://github.com/github/semmle-code/actions/workflows/__swift-prebuild.yml) with the appropriate swift
tag.
tag, e.g., `swift-6.1.1-RELEASE`.
Comment on lines 5 to +6
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider merging this nested bullet into the main list item for readability. For example:

1. Dispatch the internal `swift-prebuild` workflow with the appropriate Swift tag (e.g., `swift-6.1.1-RELEASE`).

Copilot uses AI. Check for mistakes.
2. Dispatch [internal `swift-prepare-resource-dir` workflow](https://github.com/github/semmle-code/actions/workflows/__swift-prepare-resource-dir.yml) with the
appropriate swift tag.
appropriate swift tag, e.g., `swift-6.1.1-RELEASE`.
Comment on lines 7 to +8
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Similarly, integrate this example into the numbered step to avoid an extra nested bullet. For example:

2. Dispatch the internal `swift-prepare-resource-dir` workflow with the appropriate Swift tag (e.g., `swift-6.1.1-RELEASE`).

Copilot uses AI. Check for mistakes.
3. Once the jobs finish, staged artifacts are available
at https://github.com/dsp-testing/codeql-swift-artifacts/releases. Copy and paste the sha256 within the `_override`
definition in [`load.bzl`](../load.bzl).
Expand Down