Skip to content

Conversation

@JordyZomer
Copy link
Contributor

@JordyZomer JordyZomer commented Jan 9, 2025

This PR adds bigquery's Client.Query to the SQL framework module for Go. This allows it to be used as a sink in SQL injection queries.

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

Can be used as a sink for SQL injection queries.

Signed-off-by: Jordy Zomer <[email protected]>
@JordyZomer JordyZomer requested a review from a team as a code owner January 9, 2025 13:36
@github-actions github-actions bot added the Go label Jan 9, 2025
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. It looks fundamentally correct. Two things it is missing: a change note (guide here) and a test (like this). Also, it would be much more concise as a models-as-data model (docs here, example for a different library here).

@owen-mc
Copy link
Contributor

owen-mc commented Jan 21, 2025

@JordyZomer Did you see the changes I suggested? Do you think you'll be able to do them? If not then I can take it over and make sure this model gets merged so others can benefit from it.

@owen-mc
Copy link
Contributor

owen-mc commented May 22, 2025

Superseded by #19561

@owen-mc owen-mc closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants