Skip to content

Conversation

MartinForReal
Copy link

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@MartinForReal MartinForReal requested a review from a team as a code owner September 12, 2024 05:55
@github-actions github-actions bot added the Go label Sep 12, 2024
@MartinForReal MartinForReal changed the title go: bump go to 1.23 in go extractor Go: bump go to 1.23 in go extractor Sep 12, 2024
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MartinForReal,

Thanks for opening this PR. Please note that we have already merged the changes needed to support Go 1.23 (assuming your intention with this PR was to do that), which are currently pending release in this week's CodeQL release. This release comes from the rc/3.15 branch and the changes will be merged back into main.

For future reference, while bumping the version in go.mod is a small part of what's needed, there are a bunch of other changes that are also needed. The additional constants you've introduced are not needed and the replacements of the 1.21 constants for a 1.23 one are logic errors since those checks guard autobuilder behaviour that should (or should not) run for 1.21 and above.

I'll go ahead and close this PR since it is not needed.

@mbg mbg closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants