Data Flow: Deprecate old data flow api. #14983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
python/ql/lib/semmle/python/dataflow/new/internal/tainttracking1/TaintTrackingImpl.qll
Fixed
Show fixed
Hide fixed
|
Fix for the coding standards tests: github/codeql-coding-standards#468 |
hvitved
reviewed
Dec 4, 2023
| @@ -14,6 +14,8 @@ import FlowStateString | |||
| private import codeql.util.Unit | |||
There was a problem hiding this comment.
I think we should deprecate the FlowStateString module in DataFlowImplCommon.qll as well.
There was a problem hiding this comment.
Agree, but I figured that was slightly more likely to break something, so I initially left it out, in order to hopefully merge this faster. Then deprecation of FlowStateString can follow in another PR.
Avoids some deprecation warnings :)
aschackmull
force-pushed
the
dataflow/deprecate-old-api
branch
from
8a16b85 to
46531e6
Compare
I had missed these originally, since I had just fixed the ones that were highlighted in the actions logs, thinking they had covered everything :(
jketema
approved these changes
Dec 8, 2023
hvitved
approved these changes
Dec 8, 2023
jketema
approved these changes
Dec 8, 2023
|
This probably still needs some change notes? |
|
Merging. I've put the change note in a separate PR to avoid re-running all the CI: #15046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.