Skip to content

Add support for new analysis summaries #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2023
Merged

Add support for new analysis summaries #1753

merged 2 commits into from
Jul 6, 2023

Conversation

@henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Jul 5, 2023

  • When the feature flag is enabled and the version of the CLI is >= 2.14.0, pass --new-analysis-summary to results interpretation.
  • If the feature flag isn't enabled and the version of the CLI is >= 2.14.0, pass --no-new-analysis-summary to results interpretation to ensure the feature flag continues to have the desired effect when the new analysis summary is made the default in the CLI.
  • Otherwise, do nothing.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner July 5, 2023 18:04
angelapwen
angelapwen previously approved these changes Jul 6, 2023
View reviewed changes
Base automatically changed from henrymercer/export-config-by-default to main July 6, 2023 09:57
@henrymercer henrymercer dismissed angelapwen’s stale review July 6, 2023 09:57

The base branch was changed.

@henrymercer henrymercer requested a review from angelapwen July 6, 2023 09:57
@henrymercer henrymercer merged commit a2d725d into main Jul 6, 2023
@henrymercer henrymercer deleted the henrymercer/new-analysis-summary branch July 6, 2023 10:46
@github-actions github-actions bot mentioned this pull request Jul 6, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@angelapwen angelapwen angelapwen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henrymercer @angelapwen