This repository was archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Check Run Annotations Inline #1900
Merged
grokys
merged 138 commits into
features/check-suite-annotations
from
features/check-suite-annotations-inline
Nov 26, 2018
Merged
Check Run Annotations Inline #1900
grokys
merged 138 commits into
features/check-suite-annotations
from
features/check-suite-annotations-inline
Nov 26, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uite-annotations-inline
2be4eda
to
2dfcf5d
Compare
fbb7805
to
bb30e4d
Compare
…otations' into features/check-suite-annotations-inline
…uite-annotations-inline
…uite-annotations-inline
060ff93
to
c1c229f
Compare
…uite-annotations-inline # Conflicts: # src/GitHub.App/SampleData/PullRequestAnnotationsViewModelDesigner.cs # src/GitHub.App/ViewModels/GitHubPane/PullRequestAnnotationItemViewModel.cs # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs # src/GitHub.VisualStudio/Views/GitHubPane/PullRequestAnnotationsView.xaml # src/GitHub.VisualStudio/Views/GitHubPane/PullRequestFilesView.xaml
…uite-annotations-inline # Conflicts: # src/GitHub.App/SampleData/PullRequestAnnotationItemViewModelDesigner.cs # src/GitHub.App/SampleData/PullRequestAnnotationsViewModelDesigner.cs # src/GitHub.App/ViewModels/GitHubPane/PullRequestAnnotationItemViewModel.cs # src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs # src/GitHub.Exports.Reactive/Models/IInlineAnnotationModel.cs # src/GitHub.Exports.Reactive/Models/InlineAnnotationModel.cs # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
…uite-annotations-inline # Conflicts: # src/GitHub.App/ViewModels/GitHubPane/PullRequestAnnotationItemViewModel.cs # src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestAnnotationItemViewModel.cs # src/GitHub.Exports/Models/CheckRunModel.cs
…update-check-icon # Conflicts: # src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml
It was causing alignment to go a bit weird and wasn't really needed anyway.
WIP: Prefer text instead of icon in checks list
…hub.com/github/VisualStudio into features/check-suite-annotations-inline
…hub.com/github/VisualStudio into features/check-suite-annotations-inline
Update inline review / annotation margin glyph
…uite-annotations-inline
StanleyGoldman
commented
Nov 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ASDF
StanleyGoldman
commented
Nov 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asdf
1 task
…-inline-available-for-comment Check Run Annotations should be able to disable the Add Comment functionality
…uite-annotations-inline
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This pull request targets #1864 -
features/check-suite-annotations
This pull request adds additional annotation functionality:
Remaining:
Images