Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Sep 5, 2018

Note: This pull request targets #1864 - features/check-suite-annotations

This pull request adds additional annotation functionality:

  • Display annotations in an inline review (previously an inline comment)
    • Inline reviews appear on top of existing comments or the functionality to create a new comment.
    • Separate tags for annotations with comments, annotations without comments
  • The pull request file list view annotation counts now link a user to the first inline annotation of a matching type.
  • The pull request annotation list view will now link a user to the direct annotation (only if the annotation is contained in a file changed in that pull request)

Remaining:

  • Design work

Images

image

image

@StanleyGoldman StanleyGoldman force-pushed the features/check-suite-annotations branch from 2be4eda to 2dfcf5d Compare September 6, 2018 20:55
@StanleyGoldman StanleyGoldman force-pushed the features/check-suite-annotations-inline branch from fbb7805 to bb30e4d Compare September 6, 2018 20:55
@github github deleted a comment from codecov bot Sep 6, 2018
@StanleyGoldman StanleyGoldman force-pushed the features/check-suite-annotations-inline branch from 060ff93 to c1c229f Compare September 10, 2018 20:09
…uite-annotations-inline

# Conflicts:
#	src/GitHub.App/SampleData/PullRequestAnnotationsViewModelDesigner.cs
#	src/GitHub.App/ViewModels/GitHubPane/PullRequestAnnotationItemViewModel.cs
#	src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
#	src/GitHub.VisualStudio/Views/GitHubPane/PullRequestAnnotationsView.xaml
#	src/GitHub.VisualStudio/Views/GitHubPane/PullRequestFilesView.xaml
…uite-annotations-inline

# Conflicts:
#	src/GitHub.App/SampleData/PullRequestAnnotationItemViewModelDesigner.cs
#	src/GitHub.App/SampleData/PullRequestAnnotationsViewModelDesigner.cs
#	src/GitHub.App/ViewModels/GitHubPane/PullRequestAnnotationItemViewModel.cs
#	src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs
#	src/GitHub.Exports.Reactive/Models/IInlineAnnotationModel.cs
#	src/GitHub.Exports.Reactive/Models/InlineAnnotationModel.cs
#	src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
…uite-annotations-inline

# Conflicts:
#	src/GitHub.App/ViewModels/GitHubPane/PullRequestAnnotationItemViewModel.cs
#	src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestAnnotationItemViewModel.cs
#	src/GitHub.Exports/Models/CheckRunModel.cs
StanleyGoldman and others added 4 commits November 21, 2018 10:43
…update-check-icon

# Conflicts:
#	src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml
It was causing alignment to go a bit weird and wasn't really needed anyway.
WIP: Prefer text instead of icon in checks list
@github github deleted a comment from codecov bot Nov 21, 2018
@github github deleted a comment from codecov bot Nov 21, 2018
Copy link
Contributor Author

@StanleyGoldman StanleyGoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASDF

Copy link
Contributor Author

@StanleyGoldman StanleyGoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

StanleyGoldman and others added 3 commits November 26, 2018 08:39
…-inline-available-for-comment

Check Run Annotations should be able to disable the Add Comment functionality
@github github deleted a comment from codecov bot Nov 26, 2018
@grokys grokys merged commit fef4a16 into features/check-suite-annotations Nov 26, 2018
@grokys grokys deleted the features/check-suite-annotations-inline branch November 26, 2018 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants