Harden regex for PR description footer detection #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent Gitgitgadget PR [1] demonstrates that GGG fails to parse CC: footers if no space is found after the colon. Replace the literal space " " by the more lenient "\s*" so that CC:s are parsed correctly if any kind of whitespace, or no whitespace at all, is detected after the colon. [1] gitgitgadget/git#523 Helped-by: Johannes Schindelin <[email protected]> Signed-off-by: Philippe Blain <[email protected]>
|
@dscho I did a single commit, if you prefer [demonstrate failure + fix it] in separate commits I'll split it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent Gitgitgadget PR [1] demonstrates that GGG fails to parse
CC: footers if no space is found after the colon.
Replace the literal space " " by the more lenient "\s*" so that CC:s are
parsed correctly if any kind of whitespace, or no whitespace at all, is
detected after the colon.
[1] gitgitgadget/git#523
Helped-by: Johannes Schindelin [email protected]
Signed-off-by: Philippe Blain [email protected]