Fix stale .gitignore change, introduced via js/visual-studio #332
Conversation
On Windows, it is possible to embed additional metadata into an executable by linking in a "manifest", i.e. an XML document that describes capabilities and requirements (such as minimum or maximum Windows version). These XML documents are expected to be stored in `.manifest` files. At least _some_ Visual Studio versions auto-generate `.manifest` files when none is specified explicitly, therefore we used to ask Git to ignore them. However, we do have a beautiful `.manifest` file now: `compat/win32/git.manifest`, so neither does Visual Studio auto-generate a manifest for us, nor do we want Git to ignore the `.manifest` files anymore. Further reading on auto-generated `.manifest` files: https://docs.microsoft.com/en-us/cpp/build/manifest-generation-in-visual-studio Signed-off-by: Johannes Schindelin <[email protected]>
|
/submit |
|
Submitted as [email protected] |
|
Can you give me permission to submit over at #330? |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
| @@ -231,7 +231,6 @@ | |||
| *.ipdb | |||
There was a problem hiding this comment.
On the Git mailing list, Junio C Hamano wrote (reply to this):
"Johannes Schindelin via GitGitGadget" <[email protected]>
writes:
> ...
> Further reading on auto-generated `.manifest` files:
> https://docs.microsoft.com/en-us/cpp/build/manifest-generation-in-visual-studio
>
> Signed-off-by: Johannes Schindelin <[email protected]>
> ---
> .gitignore | 1 -
> 1 file changed, 1 deletion(-)
Thanks.
> diff --git a/.gitignore b/.gitignore
> index 521d8f4fb4..fc445edea9 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -231,7 +231,6 @@
> *.ipdb
> *.dll
> .vs/
> -*.manifest
> Debug/
> Release/
> /UpgradeLog*.htm
|
This branch is now known as |
|
This patch series was integrated into pu via git@7c48707. |
|
This patch series was integrated into pu via git@c2bd993. |
|
This patch series was integrated into pu via git@7e1ccb5. |
|
This patch series was integrated into next via git@5493ee9. |
|
This patch series was integrated into pu via git@fa3aa0f. |
|
This patch series was integrated into pu via git@40d2ce4. |
|
This patch series was integrated into pu via git@b3324f8. |
|
This patch series was integrated into pu via git@9921c3c. |
|
This patch series was integrated into pu via git@59438be. |
|
This patch series was integrated into master via git@59438be. |
|
Closed via 59438be. |
As reported in https://public-inbox.org/git/[email protected]/, we added a line to ignore
.manifestfiles, but that is a left-over from a long time ago, before we added and usedcompat/win32/git.manifest.This fixes that left-over.