doc: small formatting fix #330

camsteffen · 2019-09-03T16:26:58Z

Move a closing backtick that was placed one character too soon.

gitgitgadget · 2019-09-03T16:27:36Z

Welcome to GitGitGadget

Hi @camsteffen, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

the lines should not exceed 76 columns,
the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
the commit messages' body should be describing the "why?" of the change.
Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form /allow <username>.

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

camsteffen · 2019-09-03T16:37:51Z

@derrickstolee can I pick on you to give me permission to submit?

camsteffen · 2019-09-05T16:28:13Z

/submit

gitgitgadget · 2019-09-05T16:29:03Z

Error: User camsteffen is not permitted to use GitGitGadget

dscho · 2019-09-09T21:37:50Z

/allow camsteffen

gitgitgadget · 2019-09-09T21:38:43Z

User camsteffen is now allowed to use GitGitGadget.

camsteffen · 2019-09-09T23:20:05Z

/submit

gitgitgadget · 2019-09-09T23:21:16Z

Submitted as [email protected]

gitgitgadget · 2019-09-11T11:51:43Z

On the Git mailing list, Derrick Stolee wrote (reply to this):

On 9/9/2019 7:21 PM, Cameron Steffen via GitGitGadget wrote:
> Edit: I need permission to submit please

Hi Cameron.

When using GitGitGadget, your PR description becomes your cover letter on the mailing list. This is a great place for you to describe how you discovered this problem and if you have looked elsewhere for similar issues to fix up.

Thanks,
-Stolee
> 
> Cameron Steffen (1):
>   doc: small formatting fix
> 
>  Documentation/pretty-formats.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-330%2Fcamsteffen%2Fpatch-1-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-330/camsteffen/patch-1-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/330
>

gitgitgadget · 2019-09-11T11:51:44Z

Documentation/pretty-formats.txt

@@ -208,7 +208,7 @@ endif::git-rev-list[]
 '%GP':: show the fingerprint of the primary key whose subkey was used


On the Git mailing list, Derrick Stolee wrote (reply to this):

On 9/9/2019 7:21 PM, Cameron Steffen via GitGitGadget wrote: > From: Cameron Steffen <[email protected]> > > move an incorrectly placed backtick The change below is simple enough, but we prefer using full sentences in the commit messages. This includes capitalization and punctuation. Thanks, -Stolee > Signed-off-by: Cameron Steffen <[email protected]> > --- > Documentation/pretty-formats.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt > index 079598307a..b87e2e83e6 100644 > --- a/Documentation/pretty-formats.txt > +++ b/Documentation/pretty-formats.txt > @@ -208,7 +208,7 @@ endif::git-rev-list[] > '%GP':: show the fingerprint of the primary key whose subkey was used > to sign a signed commit > '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2 > - minutes ago`}; the format follows the rules described for the > + minutes ago}`; the format follows the rules described for the > `-g` option. The portion before the `@` is the refname as > given on the command line (so `git log -g refs/heads/master` > would yield `refs/heads/master@{0}`). >

Move a closing backtick that was placed one character too soon. Signed-off-by: Cameron Steffen <[email protected]>

camsteffen · 2019-09-11T14:50:15Z

/submit

gitgitgadget · 2019-09-11T14:50:48Z

Error: Ignoring PR with empty title and/or body

camsteffen · 2019-09-11T14:52:08Z

/submit

gitgitgadget · 2019-09-11T14:53:02Z

Submitted as [email protected]

gitgitgadget · 2019-09-11T21:25:04Z

On the Git mailing list, Johannes Schindelin wrote (reply to this):

Hi Cameron,

On Mon, 9 Sep 2019, Cameron Steffen via GitGitGadget wrote:

> Edit: I need permission to submit please

You got that permission already ;-)

Ciao,
Johannes

>
> Cameron Steffen (1):
>   doc: small formatting fix
>
>  Documentation/pretty-formats.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-330%2F=
camsteffen%2Fpatch-1-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-330/camst=
effen/patch-1-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/330
> --
> gitgitgadget
>

gitgitgadget · 2019-09-12T18:07:49Z

Documentation/pretty-formats.txt

@@ -208,7 +208,7 @@ endif::git-rev-list[]
 '%GP':: show the fingerprint of the primary key whose subkey was used


On the Git mailing list, Junio C Hamano wrote (reply to this):

"Cameron Steffen via GitGitGadget" <[email protected]> writes: > From: Cameron Steffen <[email protected]> > > Move a closing backtick that was placed one character too soon. > > Signed-off-by: Cameron Steffen <[email protected]> > --- > Documentation/pretty-formats.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for spotting and fixing. Will apply. > > diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt > index 079598307a..b87e2e83e6 100644 > --- a/Documentation/pretty-formats.txt > +++ b/Documentation/pretty-formats.txt > @@ -208,7 +208,7 @@ endif::git-rev-list[] > '%GP':: show the fingerprint of the primary key whose subkey was used > to sign a signed commit > '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2 > - minutes ago`}; the format follows the rules described for the > + minutes ago}`; the format follows the rules described for the > `-g` option. The portion before the `@` is the refname as > given on the command line (so `git log -g refs/heads/master` > would yield `refs/heads/master@{0}`).

gitgitgadget · 2019-09-12T22:00:38Z

This branch is now known as cs/pretty-formats-doc-typofix.

gitgitgadget · 2019-09-12T22:00:40Z

This patch series was integrated into pu via git@d7f9ce0.

gitgitgadget · 2019-09-16T21:51:30Z

This patch series was integrated into pu via git@7259d91.

gitgitgadget · 2019-09-17T22:23:48Z

This patch series was integrated into pu via git@93592da.

gitgitgadget · 2019-09-18T19:51:38Z

This patch series was integrated into pu via git@a53b884.

gitgitgadget · 2019-09-18T22:59:36Z

This patch series was integrated into pu via git@4470493.

gitgitgadget · 2019-09-20T20:51:22Z

This patch series was integrated into pu via git@dc70ce7.

gitgitgadget · 2019-09-30T09:07:30Z

This patch series was integrated into pu via git@24df5cd.

gitgitgadget · 2019-09-30T09:07:31Z

This patch series was integrated into next via git@a29a425.

gitgitgadget · 2019-10-02T09:03:41Z

This patch series was integrated into pu via git@0c05222.

gitgitgadget · 2019-10-03T05:05:03Z

This patch series was integrated into pu via git@877d754.

gitgitgadget · 2019-10-04T07:38:52Z

This patch series was integrated into pu via git@d1d1bd3.

gitgitgadget · 2019-10-06T03:56:16Z

This patch series was integrated into pu via git@f2052f1.

gitgitgadget · 2019-10-07T03:47:48Z

This patch series was integrated into pu via git@cb3ec6f.

gitgitgadget · 2019-10-07T03:47:49Z

This patch series was integrated into next via git@cb3ec6f.

gitgitgadget · 2019-10-07T03:47:50Z

This patch series was integrated into master via git@cb3ec6f.

gitgitgadget · 2019-10-07T03:47:53Z

Closed via cb3ec6f.

camsteffen force-pushed the patch-1 branch from 79d9936 to 5248e33 Compare September 3, 2019 16:34

camsteffen mentioned this pull request Sep 5, 2019

Fix stale .gitignore change, introduced via js/visual-studio #332

Closed

weekly-digest bot mentioned this pull request Sep 8, 2019

Weekly Digest (1 September, 2019 - 8 September, 2019) #336

Closed

gitgitgadget bot reviewed Sep 11, 2019

View reviewed changes

doc: minor formatting fix

8e64007

Move a closing backtick that was placed one character too soon. Signed-off-by: Cameron Steffen <[email protected]>

camsteffen force-pushed the patch-1 branch from 5248e33 to 8e64007 Compare September 11, 2019 14:49

gitgitgadget bot reviewed Sep 12, 2019

View reviewed changes

gitgitgadget bot added the pu label Sep 12, 2019

weekly-digest bot mentioned this pull request Sep 15, 2019

Weekly Digest (8 September, 2019 - 15 September, 2019) #338

Closed

weekly-digest bot mentioned this pull request Sep 22, 2019

Weekly Digest (15 September, 2019 - 22 September, 2019) #350

Closed

gitgitgadget bot added the next label Sep 30, 2019

gitgitgadget bot added the master label Oct 7, 2019

gitgitgadget bot closed this Oct 7, 2019

		@@ -208,7 +208,7 @@ endif::git-rev-list[]
		'%GP':: show the fingerprint of the primary key whose subkey was used

doc: small formatting fix #330

doc: small formatting fix #330

Uh oh!

Conversation

camsteffen commented Sep 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitgitgadget bot commented Sep 3, 2019

Welcome to GitGitGadget

Contributing the patches

Uh oh!

camsteffen commented Sep 3, 2019

Uh oh!

camsteffen commented Sep 5, 2019

Uh oh!

gitgitgadget bot commented Sep 5, 2019

Uh oh!

dscho commented Sep 9, 2019

Uh oh!

gitgitgadget bot commented Sep 9, 2019

Uh oh!

camsteffen commented Sep 9, 2019

Uh oh!

gitgitgadget bot commented Sep 9, 2019

Uh oh!

gitgitgadget bot commented Sep 11, 2019

Uh oh!

gitgitgadget bot Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

camsteffen commented Sep 11, 2019

Uh oh!

gitgitgadget bot commented Sep 11, 2019

Uh oh!

camsteffen commented Sep 11, 2019

Uh oh!

gitgitgadget bot commented Sep 11, 2019

Uh oh!

gitgitgadget bot commented Sep 11, 2019

Uh oh!

gitgitgadget bot Sep 12, 2019

Choose a reason for hiding this comment

Uh oh!

gitgitgadget bot commented Sep 12, 2019

Uh oh!

gitgitgadget bot commented Sep 12, 2019

Uh oh!

gitgitgadget bot commented Sep 16, 2019

Uh oh!

gitgitgadget bot commented Sep 17, 2019

Uh oh!

gitgitgadget bot commented Sep 18, 2019

Uh oh!

gitgitgadget bot commented Sep 18, 2019

Uh oh!

gitgitgadget bot commented Sep 20, 2019

Uh oh!

gitgitgadget bot commented Sep 30, 2019

Uh oh!

gitgitgadget bot commented Sep 30, 2019

Uh oh!

gitgitgadget bot commented Oct 2, 2019

Uh oh!

gitgitgadget bot commented Oct 3, 2019

Uh oh!

gitgitgadget bot commented Oct 4, 2019

Uh oh!

gitgitgadget bot commented Oct 6, 2019

Uh oh!

gitgitgadget bot commented Oct 7, 2019

Uh oh!

gitgitgadget bot commented Oct 7, 2019

Uh oh!

gitgitgadget bot commented Oct 7, 2019

Uh oh!

gitgitgadget bot commented Oct 7, 2019

Uh oh!

Uh oh!

camsteffen commented Sep 3, 2019 •

edited

Loading