Skip to content

Fix two issues pointed out by Coverity #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix two issues pointed out by Coverity #221

wants to merge 2 commits into from

Conversation

dscho
Copy link
Member

@dscho dscho commented May 21, 2019

I looked very briefly over the issues pointed out by Coverity, and decided to pluck these two low-hanging pieces of fruit.

dscho added 2 commits May 21, 2019 14:43
@dscho
rebase: replace incorrect logical negation by correct bitwise one
aa0acf4 
In bff014d (builtin rebase: support the `verbose` and `diffstat`
options, 2018-09-04), we added a line that wanted to remove the
`REBASE_DIFFSTAT` bit from the flags, but it used an incorrect negation.

Found by Coverity.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
bisect--helper: verify HEAD could be parsed before continuing
f5fa20d 
In 06f5608 (bisect--helper: `bisect_start` shell function partially
in C, 2019-01-02), we introduced a call to `get_oid()` and did not check
whether it succeeded before using its output.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho added the ready to submit Has commits that have not been submitted yet label May 21, 2019
@dscho
Copy link
Member Author

dscho commented May 21, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented May 21, 2019

Submitted as [email protected]

@dscho dscho force-pushed the address-coverity-reports branch from f5fa20d to 3667755 Compare May 21, 2019 18:00
@weekly-digest weekly-digest bot mentioned this pull request May 26, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented May 28, 2019

This branch is now known as js/bisect-helper-check-get-oid-return-value.

@gitgitgadget
Copy link

gitgitgadget bot commented May 28, 2019

This patch series was integrated into pu via git@1dc498b.

@gitgitgadget gitgitgadget bot added the pu label May 28, 2019
@dscho dscho force-pushed the address-coverity-reports branch from 3667755 to f5fa20d Compare May 29, 2019 18:29
@dscho
Copy link
Member Author

dscho commented May 29, 2019

This branch is now known as js/bisect-helper-check-get-oid-return-value.

The PR was actually split in half, and the first patch can be found in js/rebase-config-bitfix.

@gitgitgadget
Copy link

gitgitgadget bot commented May 29, 2019

This patch series was integrated into pu via git@d90f5fa.

@gitgitgadget
Copy link

gitgitgadget bot commented May 29, 2019

This patch series was integrated into pu via git@3ea2b34.

@gitgitgadget
Copy link

gitgitgadget bot commented May 29, 2019

This patch series was integrated into next via git@24125b3.

@gitgitgadget gitgitgadget bot added the next label May 29, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented May 30, 2019

This patch series was integrated into pu via git@ef72851.

@gitgitgadget
Copy link

gitgitgadget bot commented May 30, 2019

This patch series was integrated into pu via git@3ba8c38.

@dscho dscho removed the ready to submit Has commits that have not been submitted yet label May 31, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jun 2, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Jun 3, 2019

This patch series was integrated into pu via git@da2f5e6.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 6, 2019

This patch series was integrated into pu via git@61aaf34.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 7, 2019

This patch series was integrated into pu via git@9344a71.

@weekly-digest weekly-digest bot mentioned this pull request Jun 9, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Jun 10, 2019

This patch series was integrated into pu via git@2161b1d.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 12, 2019

This patch series was integrated into pu via git@e50b1d4.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 13, 2019

This patch series was integrated into pu via git@710f5c3.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 14, 2019

This patch series was integrated into pu via git@b172777.

@weekly-digest weekly-digest bot mentioned this pull request Jun 16, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Jun 18, 2019

This patch series was integrated into pu via git@5b476dc.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 18, 2019

This patch series was integrated into next via git@5b476dc.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 18, 2019

This patch series was integrated into master via git@5b476dc.

@gitgitgadget gitgitgadget bot added the master label Jun 18, 2019
@gitgitgadget gitgitgadget bot closed this Jun 18, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Jun 18, 2019

Closed via 5b476dc.

@dscho dscho deleted the address-coverity-reports branch June 18, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master next pu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dscho