hasconfig support in gitoxide
#5478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utlerapp#5420) This adds support for `includeIf` directives with the `hasconfig` condition, something commonly used for user information which affects commits in GitButler.
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
krlvi
approved these changes
Nov 7, 2024
Member
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
includeIfdirectives with thehasconfigcondition,something commonly used for user information which affects commits in GitButler.
Fixes #5420.
Tasks
gitoxideupdateNotes for the Reviewer
This was validated via
gixtest, and by testing it in GitButler specifically.To do that, the global configuration was changed to use an
[includeIf "hasconfig:remote.*.url:<url-to-match>"]directive whose path then points to a new git configuration file that sets theuser.nameanduser.emailto a marker value. This value can then be observed when opening a repository whose URL matches in GitButler, and creating a commit.