added new connector type #777
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question:
|
|
@gitbrent I have updated my very old PR to fit the new TS updates done. Let me know what you think |
|
I like what you've done, but I need to think about how best to create and utilize source/target ids. |
|
sure @gitbrent , let me know what you'd think is the best way forward and I can adjust to your idea |
|
Happy to help with this PR if needed! What would be useful to do? |
|
Status update: I'm just sitting on this. Connectors are a fine addition, but i've been prioritizing more widely-used features... |
|
@gitbrent Is there any other reason this hasn't been merged? Are you waiting on anything in particular? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new options to allow users to add connector between shapes