Work around that pesky Homebrew perforce problem
#2359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
force-pushed
the
homebrew-perforce
branch
from
01cd700 to
84db932
Compare
It still fails! *Still!* Even after upgrading the cask's definition in the PR Homebrew/homebrew-cask#70981 does it fail. The explanation is, as Gábor Szeder dug out from the commit history: the local definitions might get stale and need to be updated. So let's just update them in case `brew cask install perforce` fails, and just try again! This will still fail, of course, when `homebrew-cask` falls behind Perforce's release schedule. But once it is updated, we can now simply re-run the failed jobs and they will pick up that update. As to updating `homebrew-cask`: I started automating this, via https://dev.azure.com/gitgitgadget/git/_build?definitionId=11&_a=summary (I plan on finishing it once the next Perforce upgrade comes around.) Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
homebrew-perforce
branch
from
84db932 to
625db81
Compare
dscho
changed the title
perforce problem
derrickstolee
approved these changes
Oct 17, 2019
dscho
added a commit
that referenced
this pull request
Oct 17, 2019
Work around that pesky Homebrew `perforce` problem
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just pushed a fix that was also contributed to git.git via gitgitgadget#400, but it still does not fix the problem.
Turns out that @szeder was spot on when he said that we were reluctant to switch to
brew cask install perforcebecause stale caches could cause a problem: theperforcerecipe downloads the latest binaries from Perforce's website, and when that changes, the recipe needs to be updated with the new version number and the new SHA-256. Perforce updated that file on Fri, 11 Oct 2019 20:53:43 GMT most recently, and I offered a PR to update the recipe, and even though that PR was merged, the Azure Pipeline still failed because it still had the old version.Let's work around this by falling back to pulling
homebrew-cask'smaster. As long as theperforcerecipe in that repository is updated, we will be fine. To make sure that it is updated, I started implementing an Azure Pipeline to do that. With the change in this PR, we can always re-run the jobs afterhomebrew-caskwas updated in order to turn the jobs green.