Fix a network drive related bug in the new, fast FSCache #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NtQueryDirectoryFile() call works best (and on Windows 8.1 and earlier, it works *only*) with buffer sizes up to 64kB. Which is 32k wide characters, so let's use that as our buffer size. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
fscache-gfw
branch
2 times, most recently
from
7971adc to
32e6742
Compare
|
Sorry for not merging earlier, I wanted to merge git-for-windows/MINGW-packages#34 first so that its changes would be part of the next automatically built snapshot. |
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported in #1989 and #2022 that our new FSCache code (which is quite a bit faster than the old version, partially due to using a low-level API instead of a high-level API) caused regressions on network drives in combination with older Windows versions than Windows 10.
This PR fixes it by adjusting the buffer size to accommodate the limits on older Windows versions (and remember, if the server has an older version, this bug hits, too).