Skip to content

Conversation

TheSnoozer
Copy link
Collaborator

@TheSnoozer TheSnoozer commented Jun 8, 2021

This MR includes the following items:

  • Fix the tests for java 16 by passing the --illegal-access=permit into maven-surefire-plugin. This options must be configurable, since a java8 doesn't understand this flag.
  • Add java17-ea to the test matrix
  • update some dependencies (see commits for details)

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

@TheSnoozer TheSnoozer added this to the 4.0.5 milestone Jun 8, 2021
@TheSnoozer TheSnoozer changed the title Fix tests for java16+update deps Fix tests for java16+add java17-ea to the test matrix and update dependencies Jun 8, 2021
@TheSnoozer TheSnoozer merged commit 7b66821 into git-commit-id:master Jun 8, 2021
@TheSnoozer TheSnoozer deleted the fix-tests-java16 branch June 8, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant