Explicitly hides commit sigs #548 #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevarga
changed the title
|
Wow, nice find! Thank you for creating an issue and the MR to fix it! This command line option seems to have been added with git/git@aa37999 (v2.10.0-rc0) which was released in ~ 2016. Based on that I hope that no one uses an older version of git. Besides that the failing tests seems to be actually green. I still need to understand why the java 16 tests are failing, but that's not relevant to this fix. Thanks for your contribution! |
thomasdarimont
added a commit
to thomasdarimont/embedded-spring-boot-keycloak-server
that referenced
this pull request
Sep 17, 2021
As a Workaround for a build error on jitpack. ``` [ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:4.9.10:revision (git-commit-id-on-validate-revision) on project embedded-keycloak-server-spring-boot-parent: Could not complete Mojo execution... pl.project13.core.NativeGitProvider$NativeCommandException: Git command exited with invalid status [128]: directory: `/home/jitpack/build`, command: `git log -1 --pretty=format:%an --no-show-signature HEAD`, stdout: ``, stderr: `fatal: unrecognized argument: --no-show-signature` -> [Help 1] ``` This was introduced in version 4.0.5 via: git-commit-id/git-commit-id-maven-plugin#549 Signed-off-by: Thomas Darimont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This fixes #548
Contributor Checklist
mvn clean packagecheckstylecoding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B