add support for author and commiter times #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vise890
force-pushed
the
comm-auth-times
branch
from
575f3e3 to
fc7e2cd
Compare
|
Hello, Perhaps simply: |
vise890
force-pushed
the
comm-auth-times
branch
from
fc7e2cd to
0275c60
Compare
|
ah i see, i've renamed to |
TheSnoozer
reviewed
Feb 19, 2021
maven/docs/using-the-plugin.md
Outdated
| |`git.commit.message.full` | Represents the raw body (unwrapped subject and body) of the commit message (`git log -1 --pretty=format:%B`) | | ||
| |`git.commit.message.short` | Represents the subject of the commit message - may *not* be suitable for filenames (`git log -1 --pretty=format:%s`) | | ||
| |`git.commit.time` | Represents the (formatted) time stamp when the commit has been performed. | | ||
| |`git.commit.time.commit` | Represents the (formatted) time stamp when the commit has been performed. | |
There was a problem hiding this comment.
Could you perhaps also rename the remaining instances (including the ones in the tests) ? :-)
Sorry to be picky here.
There was a problem hiding this comment.
no worries what so ever 😄 ! I think i got them all now?
vise890
force-pushed
the
comm-auth-times
branch
from
0275c60 to
a27e715
Compare
|
Thanks again for the contribution! Looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds support for getting the properties
git.commit.time.authorandgit.commit.time.committer.Contributor Checklist
mvn clean packagecheckstylecoding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B