Skip to content

Conversation

ryantse
Copy link
Contributor

@ryantse ryantse commented Aug 3, 2020

  • Adds a test case to verify that the written properties file can be read again.

Context

Accidentally introduced an NPE when reading an existing properties file and doing the comparison. Added a test case to ensure coverage of this case.

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

- Adds a test case to verify that the written properties file can be read again.
@ryantse
Copy link
Contributor Author

ryantse commented Aug 3, 2020

@TheSnoozer: Missed an edge case in my last pull request where setProperty cannot be passed a null. Instead, this change sets them to empty strings for the purposes of comparison. I've also added a test here to make sure that we test rereading the generated property file.

@TheSnoozer
Copy link
Collaborator

Thanks for the follow up and adding a test-case :-)
Looks reasonable for me.

@TheSnoozer TheSnoozer merged commit 5f1dea4 into git-commit-id:master Aug 3, 2020
@TheSnoozer TheSnoozer added this to the 4.0.2 milestone Aug 3, 2020
@TheSnoozer
Copy link
Collaborator

Refs #511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants