Skip to content

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Jun 12, 2020

Context

Add support for fetching build information on AWS CodeBuild.

The available environment variables in the AWS CodeBuild build environment are listed at Environment variables in build environments.

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

Copy link
Collaborator

@TheSnoozer TheSnoozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution :-)
Besides the small comment regarding the CODEBUILD_BUILD_ARN property the changes look good for me.

@TheSnoozer
Copy link
Collaborator

Thanks again for your contribution! Looks good now, I'm going ahead and merge.

@TheSnoozer TheSnoozer merged commit 4f03c11 into git-commit-id:master Jun 17, 2020
@TheSnoozer TheSnoozer added this to the 4.0.1 milestone Jun 17, 2020
@joschi joschi deleted the aws-codebuild branch June 17, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants