Skip to content

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Jun 12, 2020

Context

While Google Guava provides a lot of useful functionality, it is a rather heavy-weight dependency and was notorious for breaking backward-compatibility in the past.

There are only very few features from Google Guava used in git-commit-id-maven-plugin which could either be replaced by native Java 8 features (Files.createParentDirs()) or removed altogether (@VisibleForTesting).

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

@TheSnoozer
Copy link
Collaborator

Thank you for your contribution! Looks good for me! Thanks!

@TheSnoozer TheSnoozer merged commit b44151c into git-commit-id:master Jun 16, 2020
@TheSnoozer TheSnoozer added this to the 4.0.1 milestone Jun 16, 2020
@joschi joschi deleted the remove-guava branch June 17, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants