Remove the httpclient dependency #425
Merged
+11
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the usage of
org.apache.http.client.utils.URIBuilder
with standard JDK API to get rid of the dependencyContext (Why)
This plugin has a dependency to apache
httpclient
. Apachehttpclient
has other transitive dependencies, e.g.commons-logging
. Especiallycommons-logging
can cause class loader issues when the user's project classpath contains already a dependency tocommons-logging
.In my case i ran into:
Contributor Checklist
mvn clean package
checkstyle
coding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B