Skip to content

Conversation

TheSnoozer
Copy link
Collaborator

@TheSnoozer TheSnoozer commented Apr 29, 2019

Context

see individual commits for references or:

@TheSnoozer TheSnoozer changed the title Fixes #410 / #185 / #403 Fixes #410 / #185 / #403 / #415 Apr 30, 2019
In a multi-modules project, one can set injectAllReactorProjects to
true to add all the properties to each reactor's project, but there's
no automated effort to skip git execution if properties are already set
unless runOnlyOnce is set to true.

But runOnce has two issues itself:
- it assumes that the top-level project is included in the reactor
- it skips the whole plugin execution

To address this, detect during plugin execution if properties from a
previous project in the reactor have been already computed and added
to the current project's context, and skip git execution if this is the
case.
@TheSnoozer TheSnoozer added this to the 3.0 milestone Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants