#389 allow replacementProperty value to be empty

[jonevn]

Context

Allow for value to be empty in replacement property.

#389

Contributor Checklist

• Added relevant integration or unit tests to verify the changes
• Update the Readme or any other documentation (including relevant Javadoc)
• Ensured that tests pass locally: mvn clean package
• Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

[TheSnoozer]

Thanks for the PR! Looks good to me.
Would you also tell maven that this property is not required? (see https://github.com/git-commit-id/maven-git-commit-id-plugin/blob/master/src/main/java/pl/project13/maven/git/ReplacementProperty.java#L62)

This essentially suffers from

• https://issues.apache.org/jira/browse/MNG-6434
• https://issues.apache.org/jira/browse/MNG-5725

[TheSnoozer]

And Congratulation for the 400th issue/merge request :-)

[jonevn]

I will look into the maven property required thing. Do we want it to be possible to completely skip the value-tag?

And I was really aiming for the 400th =) Now moving on for 500 =)

[TheSnoozer]

Hi,
thanks again for the changes and sorry for the delay here. Looks good to me. I guess the default value for some nested stuff might not work properly (for the same reason the required is not working -- so the value will end up being null instead of the default). However I guess in that case the additional null check that is present should 'fix' this.

Merging.