run on eclipse incremental build if properties file was not generated #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! When merging this with |
|
I do not need it in 2.x. Since our project is quite small I enabled property update on every incremental build through workspace lifecycle-mappings. |
|
Thanks. Looks good for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may fix issue #366 while still respecting performance concerns from #269.
It use a BuildContext as described in m2e to distinguish between incremental and normal (e.g. mvn command line) builds. On incremental builds it should only run if the git.properties file is missing at all.
Additional the BuildContext can inform eclipse about the new generated file. (especially useful if file is generated in some folder not ignored by the IDE)