Add CSR merge_path SpMV for OpenMP backend #1810
Conversation
ginkgo-bot
added
mod:openmp
omp/matrix/csr_kernels.cpp
Outdated
| @@ -42,12 +42,133 @@ namespace omp { | |||
| namespace csr { | |||
|
|
|||
|
|
|||
| /** | |||
| * Computes the begin offsets into A and B for the specific diagonal | |||
There was a problem hiding this comment.
Could you rephrase this? It's unclear what A, and B are, as well as what the specific diagonal is.
omp/matrix/csr_kernels.cpp
Outdated
| * Computes the begin offsets into A and B for the specific diagonal | ||
| * | ||
| * @param diagonal the diagonal to search | ||
| * @param end_row_offsets the ending of row offsets of A |
There was a problem hiding this comment.
Also unclear. Is this the pointer to the end of the row offsets for A?
omp/matrix/csr_kernels.cpp
Outdated
| const auto nnz = static_cast<IndexType>(a->get_num_stored_elements()); | ||
| const auto num_threads = static_cast<IndexType>(omp_get_max_threads()); | ||
| // Merge list A: row end offsets | ||
| const IndexType* row_end_offsets = row_ptrs + 1; |
There was a problem hiding this comment.
is the suffix _offsets necessary? How you define it, I would just call it row_ends or maybe row_end_idxs.
There was a problem hiding this comment.
I think offsets matches the meaning not idxs.
There was a problem hiding this comment.
I use row_end_ptrs to match the same term we use in CSR
| auto row_carry_out_ptr = row_carry_out.get_data(); | ||
| auto value_carry_out_ptr = value_carry_out.get_data(); | ||
|
|
||
| // TODO: parallelize with number of cols, too. |
There was a problem hiding this comment.
If you want to, I think it's pretty simple to move this loop to the innermost loop. You just have to increase the size of value_carry_out to num_threads * c->get_size()[1].
yhmtsai
force-pushed
the
acmunich_omp_mergespmv
branch
from
0707e9f to
f5f7dfd
Compare
Co-authored-by: Marcel Koch <[email protected]>
yhmtsai
force-pushed
the
acmunich_omp_mergespmv
branch
from
f5f7dfd to
0e09c20
Compare
yhmtsai
added
1:ST:ready-to-merge
|
This PR picks the changes from #1497 by Luka Stanisic (@stanisic), applies the comments, and makes it available with advanced_spmv