Added checks for cmake,make and ctest in ci->run.sh #8200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
mofosyne
added
the
Review Complexity : Low
ggerganov
approved these changes
Jul 7, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 13, 2024
* Added checks for cmake,make and ctest * Removed erroneous whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that it is possible to run the shell script without cmake or make installed and it would just report a line number rather than a specific error.
Since llama.cpp can be build with either make or cmake we should identity when one is not installed.