Skip to content

convert : fix byte tokens for --vocab-type hfft #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

convert : fix byte tokens for --vocab-type hfft #5084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,11 +509,13 @@ def hf_tokens(self) -> Iterable[tuple[bytes, float, gguf.TokenType]]:

# Convert token text to bytes
token_text = reverse_vocab[token_id].encode("utf-8")
if re.fullmatch(br"<0x[0-9A-Fa-f]{2}>", token_text):
toktype = gguf.TokenType.BYTE
else:
toktype = self.get_token_type(token_id, self.special_ids)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to not implement this logic directly in get_token_type? It seems out of place here.


# Yield token text, score, and type
yield token_text, self.get_token_score(token_id), self.get_token_type(
token_id, self.special_ids # Reuse already stored special IDs
)
yield token_text, self.get_token_score(token_id), toktype

def get_token_type(self, token_id: int, special_ids: set[int]) -> gguf.TokenType:
# Determine token type based on whether it's a special token
Expand Down