Skip to content

Added support ccache for speedup recompilation #5002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggerganov merged 2 commits into from
Jan 20, 2024
Merged

Added support ccache for speedup recompilation #5002

ggerganov merged 2 commits into from
Jan 20, 2024

Conversation

@GermanAizek
Copy link
Contributor

@GermanAizek GermanAizek commented Jan 17, 2024

@ggerganov
Copy link
Member

ggerganov commented Jan 17, 2024

Are there cases where we want ccache disabled even if it is present?
If so, we should probably put it behind LLAMA_CCACHE CMake option

@GermanAizek
Copy link
Contributor Author

GermanAizek commented Jan 17, 2024

Are there cases where we want ccache disabled even if it is present? If so, we should probably put it behind LLAMA_CCACHE CMake option

Disabling ccache is required if you only need to benchmark build time without ccache, enabling cache is necessary when checkout git branches and recompiling. It really helps to reduce compile time.

cebtenzzre
cebtenzzre reviewed Jan 17, 2024
View reviewed changes
CMakeLists.txt Outdated
find_program(LLAMA_CCACHE_FOUND ccache)
if (LLAMA_CCACHE_FOUND)
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache)
set(ENV{CCACHE_SLOPPINESS} pch_defines,time_macros)
Copy link
Collaborator

@cebtenzzre cebtenzzre Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be best to leave out pch_defines since we don't use precompiled headers, and sloppy preprocessing in the future might lead to surprising issues.

@ggerganov
Copy link
Member

ggerganov commented Jan 17, 2024

Disabling ccache is required if you only need to benchmark build time without ccache

So it sounds we need to add LLAMA_NO_CCACHE option in order to be able to disable ccache in such situations

@ggerganov ggerganov mentioned this pull request Jan 19, 2024
Merged
7 tasks
@ggerganov ggerganov merged commit 77bc1bb into ggml-org:master Jan 20, 2024
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this pull request Feb 3, 2024
@GermanAizek @ggerganov @jordankanter
cmake : add support for ccache (ggml-org#5002)
43a5ee4 
* Added support ccache for speedup recompilation

* cmake : option to disable ccache

---------

Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

+1 more reviewer

@cebtenzzre cebtenzzre cebtenzzre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GermanAizek @ggerganov @cebtenzzre